Use mapping file provider in case of legacy Variant API #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #265 +/- ##
=============================================
- Coverage 78.25% 78.16% -0.10%
- Complexity 249 250 +1
=============================================
Files 31 31
Lines 892 911 +19
Branches 114 114
=============================================
+ Hits 698 712 +14
- Misses 144 147 +3
- Partials 50 52 +2
|
xgouchet
approved these changes
May 30, 2024
Base automatically changed from
nogorodnikov/rum-592/support-new-variant-api
to
develop
May 30, 2024 08:34
0xnm
deleted the
nogorodnikov/use-mapping-file-provider-for-legacy-variant-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes to use
Variant.mappingFileProviderin case of legacy API usage. This brings more reliable way to get a mapping file.Review checklist (to be filled by reviewers)